Remove x-ignore from table/index.blade.php#15044
Closed
angus-mcritchie wants to merge 1 commit intofilamentphp:3.xfrom
Closed
Remove x-ignore from table/index.blade.php#15044angus-mcritchie wants to merge 1 commit intofilamentphp:3.xfrom
x-ignore from table/index.blade.php#15044angus-mcritchie wants to merge 1 commit intofilamentphp:3.xfrom
Conversation
Fix for Livewire v3.5.13 bug that screen goes black after table action see discussion - filamentphp#14901
Contributor
Author
|
I'd also like to note that this pull request's goal is to bump the livewire version again; I haven't updated the |
Member
|
Unfortunately we cannot do this, the attribute is there to support the Async Alpine lazy loaded component. I think that Alpine needs to revert this breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Livewire v3.5.13 bug that screen goes black after table action see discussion - #14901
Caution
I did test this on my own project, which has multiple tables, modals, filters, etc, and everything worked as expected. However, I don't know why the
x-ignoreattribute was there is the first place. So it would be great to get this tested by others.Description
Fixes bug reported https://discord.com/channels/883083792112300104/956270111176679516/1311365505776488458 and https://discord.com/channels/883083792112300104/1313209203564871710/1313209203564871710
I think this bug was introduced by Livewire bumping the Alpine version containing this commit which prevents initialising components inside an
x-ignoreattribute.You can view the original discussion here - #14901
Visual changes
Before: screen goes black (as 5 modal backdrops display).
After: no modal backdrops and you can use the panel as normal.
Functional changes
composer cscommand.